]> asedeno.scripts.mit.edu Git - linux.git/commit
pinctrl: mediatek: mt7622: fix potential uninitialized value being returned
authorSean Wang <sean.wang@mediatek.com>
Tue, 9 Jan 2018 16:28:24 +0000 (00:28 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 11 Jan 2018 09:42:12 +0000 (10:42 +0100)
commit181cdac02c51a77f9ae497be624edb99056a0a10
tree11ea6d2fca354713f2d53bbdcbdc41e7c0974df3
parentfb36a7b07dbf565014ed624a1bfd24d807f56b85
pinctrl: mediatek: mt7622: fix potential uninitialized value being returned

commit d6ed93551320 ("pinctrl: mediatek: add pinctrl driver for MT7622
SoC") leads to the following static checker warning:

drivers/pinctrl/mediatek/pinctrl-mt7622.c:1419 mtk_gpio_get()
error: uninitialized symbol 'value'.
1412  static int mtk_gpio_get(struct gpio_chip *chip, unsigned int gpio)
1413  {
1414          struct mtk_pinctrl *hw = dev_get_drvdata(chip->parent);
1415          int value;
1416
1417          mtk_hw_get_value(hw, gpio, PINCTRL_PIN_REG_DI, &value);
^^^^^^^^^^^^^^^^
1418
1419          return !!value;
1420  }

The appropriate error handling must be added to avoid the potential error
caused by uninitialized value being returned.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/mediatek/pinctrl-mt7622.c