]> asedeno.scripts.mit.edu Git - linux.git/commit
ath9k: Protect queue draining by rcu_read_lock()
authorToke Høiland-Jørgensen <toke@toke.dk>
Tue, 27 Feb 2018 17:09:44 +0000 (19:09 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 14 Mar 2018 09:55:51 +0000 (11:55 +0200)
commit182b1917109892ab9f26d66bfdcbc4ba6f0a0a65
treef5c2be05646afedf7805781e2f4887fbf05de893
parent38a1390e02b7bfd02cabc98238e859c07d86a6d3
ath9k: Protect queue draining by rcu_read_lock()

When ath9k was switched over to use the mac80211 intermediate queues,
node cleanup now drains the mac80211 queues. However, this call path is
not protected by rcu_read_lock() as it was previously entirely internal
to the driver which uses its own locking.

This leads to a possible rcu_dereference() without holding
rcu_read_lock(); but only if a station is cleaned up while having
packets queued on the TXQ. Fix this by adding the rcu_read_lock() to the
caller in ath9k.

Fixes: 50f08edf9809 ("ath9k: Switch to using mac80211 intermediate software queues.")
Cc: stable@vger.kernel.org
Reported-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath9k/xmit.c