]> asedeno.scripts.mit.edu Git - linux.git/commit
afs: Fix callback handling
authorDavid Howells <dhowells@redhat.com>
Fri, 19 Oct 2018 23:57:59 +0000 (00:57 +0100)
committerDavid Howells <dhowells@redhat.com>
Tue, 23 Oct 2018 23:41:09 +0000 (00:41 +0100)
commit18ac61853cc4e44eb30e125fc8344a3b25c7b6fe
tree9565bfd8b0dec553d351ca13ce841a5e2bbeae7a
parent2feeaf8433c8e68de3d0a06a0ffe7742bcd13c1a
afs: Fix callback handling

In some circumstances, the callback interest pointer is NULL, so in such a
case we can't dereference it when checking to see if the callback is
broken.  This causes an oops in some circumstances.

Fix this by replacing the function that worked out the aggregate break
counter with one that actually does the comparison, and then make that
return true (ie. broken) if there is no callback interest as yet (ie. the
pointer is NULL).

Fixes: 68251f0a6818 ("afs: Fix whole-volume callback handling")
Signed-off-by: David Howells <dhowells@redhat.com>
fs/afs/fsclient.c
fs/afs/internal.h
fs/afs/security.c
fs/afs/yfsclient.c