]> asedeno.scripts.mit.edu Git - linux.git/commit
USB: serial: mos7840: use irqsave() in USB's complete callback
authorJohn Ogness <john.ogness@linutronix.de>
Sat, 23 Jun 2018 22:32:09 +0000 (00:32 +0200)
committerJohan Hovold <johan@kernel.org>
Tue, 26 Jun 2018 12:49:34 +0000 (14:49 +0200)
commit19bfbf462e8921d8e520bcc0a23ebc4988223631
tree2fa61bcfb9c45448073d34e530f8b65f9c7534bd
parentf7c8a9ccc9afe3781dfd6e1977775457102c5c83
USB: serial: mos7840: use irqsave() in USB's complete callback

The USB completion callback does not disable interrupts while acquiring
the lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/mos7840.c