]> asedeno.scripts.mit.edu Git - linux.git/commit
mt76: fix debugfs_simple_attr.cocci warnings
authorFengguang Wu <fengguang.wu@intel.com>
Thu, 14 Dec 2017 15:39:05 +0000 (16:39 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 8 Jan 2018 17:25:46 +0000 (19:25 +0200)
commit1a2b3666da582f93635a9c7be663d8100b9a303f
tree72f573732f9b1e37245ee5db3ea352accac8684b
parente3720dad99859251a8b0fe2807275a8afcfb560d
mt76: fix debugfs_simple_attr.cocci warnings

drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval should be defined with DEFINE_DEBUGFS_ATTRIBUTE

 Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
 for debugfs files.

Semantic patch information:
 Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
 imposes some significant overhead as compared to
 DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().

Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

Fixes: a5f6039c8f9c ("mt76: add driver code for MT76x2e")
CC: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/mediatek/mt76/debugfs.c