]> asedeno.scripts.mit.edu Git - linux.git/commit
ARM: dts: imx6sx-sdb: Fix enet phy regulator
authorLeonard Crestez <leonard.crestez@nxp.com>
Mon, 8 Oct 2018 15:28:01 +0000 (15:28 +0000)
committerShawn Guo <shawnguo@kernel.org>
Mon, 5 Nov 2018 02:11:04 +0000 (10:11 +0800)
commit1ad9fb750a104f51851c092edd7b3553f0218428
tree881348ae049af3ac57af389c20870d70a5e9b1b5
parent1af6ab3bac8458fc2e92ad7bb97b62de4a1fddef
ARM: dts: imx6sx-sdb: Fix enet phy regulator

Bindings for "fixed-regulator" only explicitly support "gpio" property,
not "gpios". Fix by correcting the property name.

The enet PHYs on imx6sx-sdb needs to be explicitly reset after a power
cycle, this can be handled by the phy-reset-gpios property. Sadly this
is not handled on suspend: the fec driver turns phy-supply off but
doesn't assert phy-reset-gpios again on resume.

Since additional phy-level work is required to support powering off the
phy in suspend fix the problem by just marking the regulator as
"boot-on" "always-on" so that it's never turned off. This behavior is
equivalent to older releases.

Keep the phy-reset-gpios property on fec anyway because it is a correct
description of board design.

This issue was exposed by commit efdfeb079cc3 ("regulator: fixed:
Convert to use GPIO descriptor only") which causes the "gpios" property
to also be parsed. Before that commit the "gpios" property had no
effect, PHY reset was only handled in the the bootloader.

This fixes linux-next boot failures previously reported here:
 https://lore.kernel.org/patchwork/patch/982437/#1177900
 https://lore.kernel.org/patchwork/patch/994091/#1178304

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
arch/arm/boot/dts/imx6sx-sdb.dtsi