]> asedeno.scripts.mit.edu Git - linux.git/commit
usb: typec: tcpm: Fix APDO PPS order checking to be based on voltage
authorAdam Thomson <Adam.Thomson.Opensource@diasemi.com>
Fri, 21 Sep 2018 15:04:11 +0000 (16:04 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Oct 2018 19:05:30 +0000 (12:05 -0700)
commit1b6af2f58c2b1522e0804b150ca95e50a9e80ea7
tree650d9bfe23eaeb90d953ab6a45918f19b95ca618
parente0a2e73e501c77037c8756137e87b12c7c3c9793
usb: typec: tcpm: Fix APDO PPS order checking to be based on voltage

Current code mistakenly checks against max current to determine
order but this should be max voltage. This commit fixes the issue
so order is correctly determined, thus avoiding failure based on
a higher voltage PPS APDO having a lower maximum current output,
which is actually valid.

Fixes: 2eadc33f40d4 ("typec: tcpm: Add core support for sink side PPS")
Cc: <stable@vger.kernel.org>
Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/tcpm.c