]> asedeno.scripts.mit.edu Git - linux.git/commit
xsk: do not remove umem from netdevice on fall-back to copy-mode
authorBjörn Töpel <bjorn.topel@intel.com>
Tue, 12 Feb 2019 07:51:14 +0000 (08:51 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Tue, 12 Feb 2019 16:04:45 +0000 (17:04 +0100)
commit1e405c1a3f667bf152905127b94e9c8f454a343e
treec34a89d9982bf94b3c0ab423f246e9d6bd6129e7
parente451eb51068496054d071af10b3530af4002a4f4
xsk: do not remove umem from netdevice on fall-back to copy-mode

Commit c9b47cc1fabc ("xsk: fix bug when trying to use both copy and
zero-copy on one queue id") stores the umem into the netdev._rx
struct. However, the patch incorrectly removed the umem from the
netdev._rx struct when user-space passed "best-effort" mode
(i.e. select the fastest possible option available), and zero-copy
mode was not available. This commit fixes that.

Fixes: c9b47cc1fabc ("xsk: fix bug when trying to use both copy and zero-copy on one queue id")
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
net/xdp/xdp_umem.c