]> asedeno.scripts.mit.edu Git - linux.git/commit
media: atmel: atmel-isc: fix asd memory allocation
authorEugen Hristev <eugen.hristev@microchip.com>
Fri, 12 Apr 2019 10:19:49 +0000 (06:19 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 8 May 2019 17:57:56 +0000 (13:57 -0400)
commit1e4e25c4959c10728fbfcc6a286f9503d32dfe02
treeb76333d459f67de1473498987f3a59992ec14177
parent79199002db5c571e335131856b3ff057ffd9f3c0
media: atmel: atmel-isc: fix asd memory allocation

The subsystem will free the asd memory on notifier cleanup, if the asd is
added to the notifier.
However the memory is freed using kfree.
Thus, we cannot allocate the asd using devm_*
This can lead to crashes and problems.
To test this issue, just return an error at probe, but cleanup the
notifier beforehand.

Fixes: 106267444f ("[media] atmel-isc: add the Image Sensor Controller code")
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/atmel/atmel-isc.c