]> asedeno.scripts.mit.edu Git - linux.git/commit
Staging: iio: adc: constify attribute_group structures
authorBhumika Goyal <bhumirks@gmail.com>
Mon, 26 Sep 2016 05:01:38 +0000 (10:31 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Sep 2016 11:03:57 +0000 (13:03 +0200)
commit1ed90ff342b6513f310d39c1c3e0cf341ec4698d
tree5edc41e9265e3441a126c8f8a017f7d6ec9c855e
parent4ceffe65c3fd79e75f50d4613aaefc00d81e2171
Staging: iio: adc: constify attribute_group structures

Check for attribute_group structures that are only stored in the
attrs filed of iio_info structure. As the attrs field of iio_info
structures is constant, so these attribute_group structures can also be
declared constant.
Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
struct iio_info x;
@@
x.attrs=&i@p;

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

File size before: drivers/staging/iio/adc/ad7280a.o
   text    data     bss     dec     hex filename
   6487     584     776    7847    1ea7
drivers/staging/iio/adc/ad7280a.o

File size after: drivers/staging/iio/adc/ad7280a.o
   text    data     bss     dec     hex filename
   6551     544     776    7871    1ebf
drivers/staging/iio/adc/ad7280a.o

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/iio/adc/ad7280a.c