]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/radeon: change function signature to pass full range
authorMathieu Malaterre <malat@debian.org>
Thu, 12 Apr 2018 19:33:33 +0000 (21:33 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 19 Sep 2018 17:37:25 +0000 (12:37 -0500)
commit1f81fbc4ce8211b38881b12a1100ea7ee2ffc5f0
tree7c28c74159c6d2dfa50c2ed86588384ea337c833
parent066689161a481db3940f445b34b9dd543cb8799a
drm/radeon: change function signature to pass full range

In function ‘radeon_process_i2c_ch’ a comparison of a u8 value against
255 is done. Since it is always false, change the signature of this
function to use an `int` instead, which match the type used in caller:
`radeon_atom_hw_i2c_xfer`.

Fix the following warning triggered with W=1:

  CC [M]  drivers/gpu/drm/radeon/atombios_i2c.o
  drivers/gpu/drm/radeon/atombios_i2c.c: In function ‘radeon_process_i2c_ch’:
  drivers/gpu/drm/radeon/atombios_i2c.c:71:11: warning: comparison is always false due to limited range of data type [-Wtype-limits]
   if (num > ATOM_MAX_HW_I2C_READ) {
           ^

Reviewed-by: Huang Rui <ray.huang@amd.com>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/atombios_i2c.c