]> asedeno.scripts.mit.edu Git - linux.git/commit
ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 26 Jul 2019 02:14:42 +0000 (10:14 +0800)
committerTakashi Iwai <tiwai@suse.de>
Fri, 26 Jul 2019 12:25:37 +0000 (14:25 +0200)
commit2127c01b7f63b06a21559f56a8c81a3c6535bd1a
treec93b0d77365a349af43d033a85a9ed774b8f0f5a
parentdd65f7e19c6961ba6a69f7c925021b7a270cb950
ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls()

In build_adc_controls(), there is an if statement on line 773 to check
whether ak->adc_info is NULL:
    if (! ak->adc_info ||
        ! ak->adc_info[mixer_ch].switch_name)

When ak->adc_info is NULL, it is used on line 792:
    knew.name = ak->adc_info[mixer_ch].selector_name;

Thus, a possible null-pointer dereference may occur.

To fix this bug, referring to lines 773 and 774, ak->adc_info
and ak->adc_info[mixer_ch].selector_name are checked before being used.

This bug is found by a static analysis tool STCheck written by us.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/i2c/other/ak4xxx-adda.c