]> asedeno.scripts.mit.edu Git - linux.git/commit
clk: vc5: Abort clock configuration without upstream clock
authorMarek Vasut <marek.vasut@gmail.com>
Sat, 15 Dec 2018 00:55:19 +0000 (01:55 +0100)
committerStephen Boyd <sboyd@kernel.org>
Wed, 9 Jan 2019 18:53:58 +0000 (10:53 -0800)
commit2137a109a5e39c2bdccfffe65230ed3fadbaac0e
tree46f69d35292d3d4214f9c7643b85e77cedad1bc1
parentc6e909972ef87aa2a479269f46b84126f99ec6db
clk: vc5: Abort clock configuration without upstream clock

In case the upstream clock are not set, which can happen in case the
VC5 has no valid upstream clock, the $src variable is used uninited
by regmap_update_bits(). Check for this condition and return -EINVAL
in such case.

Note that in case the VC5 has no valid upstream clock, the VC5 can
not operate correctly. That is a hardware property of the VC5. The
internal oscilator present in some VC5 models is also considered
upstream clock.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Alexey Firago <alexey_firago@mentor.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-renesas-soc@vger.kernel.org
[sboyd@kernel.org: Added comment about probe preventing this from
happening in the first place]
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk-versaclock5.c