]> asedeno.scripts.mit.edu Git - linux.git/commit
fbtft: Make sure string is NULL terminated
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 20 Nov 2019 09:57:12 +0000 (11:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Nov 2019 13:35:57 +0000 (14:35 +0100)
commit21f585480deb4bcf0d92b08879c35d066dfee030
tree3033698ae9cceb1197109e6109d964c6e57f71c2
parent7da8abcf482adcc0d84ebf619f9f841058fccdb1
fbtft: Make sure string is NULL terminated

New GCC warns about inappropriate use of strncpy():

drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_framebuffer_alloc’:
drivers/staging/fbtft/fbtft-core.c:665:2: warning: ‘strncpy’ specified bound 16 equals destination size [-Wstringop-truncation]
  665 |  strncpy(info->fix.id, dev->driver->name, 16);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Later on the copy is being used with the assumption to be NULL terminated.
Make sure string is NULL terminated by switching to snprintf().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20191120095716.26628-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fbtft/fbtft-core.c