]> asedeno.scripts.mit.edu Git - linux.git/commit
crypto: atmel-sha - remove unnecessary static in atmel_sha_remove()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 18 Jul 2017 23:04:45 +0000 (18:04 -0500)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 3 Aug 2017 05:47:16 +0000 (13:47 +0800)
commit22d96f04bb7498549ae7c130f03d7ea327744c5a
tree5af8c4db77b2e355f94cd4713b087c321f1d448f
parent0588d8500b6e7a94242c442d24ad9a55d8ad8f34
crypto: atmel-sha - remove unnecessary static in atmel_sha_remove()

Remove unnecessary static on local variable sha_dd. Such variable
is initialized before being used, on every execution path throughout
the function. The static has no benefit and, removing it reduces the
object file size.

This issue was detected using Coccinelle and the following semantic patch:
https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci

In the following log you can see a significant difference in the object
file size. This log is the output of the size command, before and after
the code change:

before:
   text    data     bss     dec     hex filename
  30005   10264     128   40397    9dcd drivers/crypto/atmel-sha.o

after:
   text    data     bss     dec     hex filename
  29934   10208      64   40206    9d0e drivers/crypto/atmel-sha.o

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/atmel-sha.c