]> asedeno.scripts.mit.edu Git - linux.git/commit
Compiler Attributes: enable -Wstringop-truncation on W=1 (gcc >= 8)
authorMiguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Wed, 19 Sep 2018 00:31:58 +0000 (02:31 +0200)
committerMiguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Sun, 30 Sep 2018 18:14:04 +0000 (20:14 +0200)
commit23066c3f4e2146da8c7d1505729f4409f4d93d28
treee72ecbf474c663b3a4c432f4a92cd80a97e08b37
parent92676236917d8e2e0de1d8612686d3d04a6a245b
Compiler Attributes: enable -Wstringop-truncation on W=1 (gcc >= 8)

Commit 217c3e019675 ("disable stringop truncation warnings for now")
disabled -Wstringop-truncation since it was too noisy.

Having __nonstring available allows us to let GCC know that a string
is not meant to be NUL-terminated, which helps suppressing some
-Wstringop-truncation warnings.

Note that using __nonstring actually triggers other warnings
(-Wstringop-overflow, which is on by default) which may be real
problems. Therefore, cleaning up -Wstringop-truncation warnings
also buys us the ability to uncover further potential problems.

To encourage the use of __nonstring, we put the warning back at W=1.
In the future, if we end up with a fairly warning-free tree,
we might want to enable it by default.

Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # on top of v4.19-rc5, clang 7
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
scripts/Makefile.extrawarn