]> asedeno.scripts.mit.edu Git - linux.git/commit
media: vim2m: only cancel work if it is for right context
authorHans Verkuil <hverkuil@xs4all.nl>
Fri, 11 Jan 2019 12:07:25 +0000 (07:07 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 16 Jan 2019 16:13:25 +0000 (11:13 -0500)
commit240809ef6630a4ce57c273c2d79ffb657cd361eb
tree794175bca1a6628ab8229f756f2f455d1ebca8b3
parent7fe9f01c04c2673bd6662c35b664f0f91888b96f
media: vim2m: only cancel work if it is for right context

cancel_delayed_work_sync() was called for any queue, but it should only
be called for the queue that is associated with the currently running job.

Otherwise, if two filehandles are streaming at the same time, then closing the
first will cancel the work which might still be running for a job from the
second filehandle. As a result the second filehandle will never be able to
finish the job and an attempt to stop streaming on that second filehandle will
stall.

Fixes: 52117be68b82 ("media: vim2m: use cancel_delayed_work_sync instead of flush_schedule_work")
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: <stable@vger.kernel.org> # for v4.20 and up
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/vim2m.c