]> asedeno.scripts.mit.edu Git - linux.git/commit
SUNRPC: Remove xdr_buf_trim()
authorChuck Lever <chuck.lever@oracle.com>
Mon, 11 Feb 2019 16:25:09 +0000 (11:25 -0500)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Thu, 14 Feb 2019 14:39:34 +0000 (09:39 -0500)
commit241b1f419f0ea9966d574d7cc67377c74982a125
treefc7d904b4c452b4ae3afa7f6786fdc27fa04570f
parent0c77668ddb4e7bdfbca462c6185d154d0b8889ae
SUNRPC: Remove xdr_buf_trim()

The key action of xdr_buf_trim() is that it shortens buf->len, the
length of the xdr_buf's content. The other actions -- shortening the
head, pages, and tail components -- are actually not necessary. In
particular, changing the size of those components can corrupt the
RPC message contained in the buffer. This is an accident waiting to
happen rather than a current bug, as far as we know.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Acked-by: Bruce Fields <bfields@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
include/linux/sunrpc/xdr.h
net/sunrpc/auth_gss/gss_krb5_wrap.c
net/sunrpc/auth_gss/svcauth_gss.c
net/sunrpc/xdr.c