]> asedeno.scripts.mit.edu Git - linux.git/commit
f2fs: fix to avoid race during access gc_thread pointer
authorChao Yu <yuchao0@huawei.com>
Mon, 28 May 2018 08:57:32 +0000 (16:57 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Thu, 31 May 2018 18:31:52 +0000 (11:31 -0700)
commit250dbf515192811025c4f3ba764a985f9b95be8e
tree387694a4b8840e81b04b601143333a6a7fdeaedf
parentaec2f729fca13661e9bc651839ae23bf8367195a
f2fs: fix to avoid race during access gc_thread pointer

Thread A Thread B
- f2fs_remount
 - stop_gc_thread
- f2fs_sbi_store
   sbi->gc_thread = NULL;
  access sbi->gc_thread->gc_*

Previously, we allocate memory for sbi->gc_thread based on background
gc thread mount option, the memory can be released if we turn off
that mount option, but still there are several places access gc_thread
pointer without considering race condition, result in NULL point
dereference.

In order to fix this issue, use sb->s_umount to exclude those operations.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/sysfs.c