]> asedeno.scripts.mit.edu Git - linux.git/commit
ASoC: soc-acpi: fix implicit header use of module.h/export.h
authorPaul Gortmaker <paul.gortmaker@windriver.com>
Sat, 13 Apr 2019 15:15:18 +0000 (11:15 -0400)
committerMark Brown <broonie@kernel.org>
Wed, 8 May 2019 09:06:28 +0000 (18:06 +0900)
commit261e90829fe2f0ab8a9e3912da1126abd3224ad7
treec33a7ffb72ec8616963a6659d9c80b567e118723
parentc0ffbd64b9dc14d673e393cc5933f3b4a47ab39c
ASoC: soc-acpi: fix implicit header use of module.h/export.h

This file is implicitly relying on an instance of including
module.h from <linux/acpi.h>.

Ideally, header files under include/linux shouldn't be adding
includes of other headers, in anticipation of their consumers,
but just the headers needed for the header itself to pass
parsing with CPP.

The module.h is particularly bad in this sense, as it itself does
include a whole bunch of other headers, due to the complexity of
module support.

Here, we make the include explicit, in order to allow the future
removal of module.h from linux/acpi.h without causing build breakage.

Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-acpi.c