]> asedeno.scripts.mit.edu Git - linux.git/commit
fsnotify: Remove useless list deletion and comment
authorJan Kara <jack@suse.cz>
Wed, 15 Mar 2017 09:08:28 +0000 (10:08 +0100)
committerJan Kara <jack@suse.cz>
Mon, 10 Apr 2017 15:37:35 +0000 (17:37 +0200)
commit2629718dd26f89e064dcdec6c8e5b9713502e1f8
tree8a5ac343005713bbaa212c368751dd7c063aed57
parent73cd3c33ab793325ebaae27fa58b4f713c16f12c
fsnotify: Remove useless list deletion and comment

After removing all the indirection it is clear that

hlist_del_init_rcu(&mark->obj_list);

in fsnotify_destroy_marks() is not needed as the mark gets removed from
the list shortly afterwards in fsnotify_destroy_mark() ->
fsnotify_detach_mark() -> fsnotify_detach_from_object(). Also there is
no problem with mark being visible on object list while we call
fsnotify_destroy_mark() as parallel destruction of marks from several
places is properly handled (as mentioned in the comment in
fsnotify_destroy_marks(). So just remove the list removal and also the
stale comment.

Reviewed-by: Miklos Szeredi <mszeredi@redhat.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/notify/mark.c