]> asedeno.scripts.mit.edu Git - linux.git/commit
serial: sh-sci: Fix fallback to PIO in sci_dma_rx_complete()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 7 Jan 2019 16:23:19 +0000 (17:23 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 Jan 2019 15:56:52 +0000 (16:56 +0100)
commit26f073993665683f1debf4d66d8bc274ac6df771
tree8cbd15adf833abe95d482de95a0ace3bf28265b7
parent38766e4b612ba10844afadf2fce12f8f90465c64
serial: sh-sci: Fix fallback to PIO in sci_dma_rx_complete()

When submitting a DMA request fails in sci_dma_rx_complete(), the driver
tries to fall back to PIO, but that does not work: no more data will be
received, or the kernel will even crash.

Fix this similar as in (but not identical to) sci_submit_rx():
  - On SCIF, PIO cannot take over if any DMA transactions are pending,
    hence they must be terminated first.
  - All active cookies must be invalidated, else rx_timer_fn() may
    trigger a NULL pointer dereference.
  - Restarting the port is not needed, as it is already running, but
    serial port interrupts must be directed back from the DMA engine to
    the CPU.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c