]> asedeno.scripts.mit.edu Git - linux.git/commit
net: phy: aquantia: replace magic numbers with constants
authorHeiner Kallweit <hkallweit1@gmail.com>
Sun, 3 Feb 2019 20:19:06 +0000 (21:19 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 3 Feb 2019 22:31:04 +0000 (14:31 -0800)
commit278f6b674f9a2b4cff73c0c8d76fc696e28e8884
treee609b5cdce7e9d0ae8a2fe4da388c30ed67a6087
parent4d5dfb666c1b58206ba6eba3c6bee0c8d6264c3d
net: phy: aquantia: replace magic numbers with constants

Replace magic numbers with proper constants. The original patch is
from Andrew, I extended / adjusted certain parts:
- Use decimal bit numbers. The datasheet uses hex bit numbers 0 .. F.
- Order defines from highest to lowest bit numbers
- correct some typos
- add constant MDIO_AN_TX_VEND_INT_MASK2_LINK
- Remove few functional improvements from the patch, they will come as
  a separate patch.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/aquantia.c