]> asedeno.scripts.mit.edu Git - PuTTY.git/commit
Fix a dangerous cross-thread memory access.
authorSimon Tatham <anakin@pobox.com>
Tue, 7 Apr 2015 21:17:08 +0000 (22:17 +0100)
committerSimon Tatham <anakin@pobox.com>
Sat, 20 Jun 2015 08:31:55 +0000 (09:31 +0100)
commit2856422eab2169928a44ebbf00e8b8d8ad7e5916
treea7a04b7ac02bf30237c8836095bf3d60d1c6ccae
parent02893bcba062ad3a39c41a6a98d4647f417d2b13
Fix a dangerous cross-thread memory access.

When a winhandl.c input thread returns EOF to the main thread, the
latter might immediately delete the input thread's context. I
carefully wrote in a comment that in that case we had to not touch ctx
ever again after signalling to the main thread - but the test for
whether that was true, which also touched ctx, itself came _after_ the
SetEvent which sent that signal. Ahem.

Spotted by Minefield, which it looks as if I haven't run for a while.

(cherry picked from commit 9fec2e773873e28f1409f5e1eefaf03483070050)
windows/winhandl.c