]> asedeno.scripts.mit.edu Git - linux.git/commit
xfs: push corruption -> ESTALE conversion to xfs_nfs_get_inode()
authorDave Chinner <dchinner@redhat.com>
Tue, 5 Jun 2018 17:09:34 +0000 (10:09 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Wed, 6 Jun 2018 15:10:26 +0000 (08:10 -0700)
commit29cad0b3edaffb65f78f61b63cb0c43f87f98865
treeaec35c16de02a9e42e33d3897b9af57f4883a5f1
parent541b5acc85916343a08f72dde17400cbb165417d
xfs: push corruption -> ESTALE conversion to xfs_nfs_get_inode()

In xfs_imap_to_bp(), we convert a -EFSCORRUPTED error to -EINVAL if
we are doing an untrusted lookup. This is done because we need
failed filehandle lookups to report -ESTALE to the caller, and it
does this by converting -EINVAL and -ENOENT errors to -ESTALE.

The squashing of EFSCORRUPTED in imap_to_bp makes it impossible for
for xfs_iget(UNTRUSTED) callers to determine the difference between
"inode does not exist" and "corruption detected during lookup". We
realy need that distinction in places calling xfS_iget(UNTRUSTED),
so move the filehandle error case handling all the way out to
xfs_nfs_get_inode() where it is needed.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/libxfs/xfs_inode_buf.c
fs/xfs/xfs_export.c