]> asedeno.scripts.mit.edu Git - linux.git/commit
regulator: da9063: Fix notifier mutex lock warning
authorSteve Twiss <stwiss.opensource@diasemi.com>
Tue, 26 Feb 2019 15:23:02 +0000 (15:23 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 13 Mar 2019 15:11:11 +0000 (15:11 +0000)
commit29d40b4a5776ec4727c9f0e00a884423dd5e3366
tree22fa519469bbfefd8d44649b513259e12be42f10
parent119c4f5085c45b60cb23c5595e45d06135b89518
regulator: da9063: Fix notifier mutex lock warning

The mutex for the regulator_dev must be controlled by the caller of
the regulator_notifier_call_chain(), as described in the comment
for that function.

Failure to mutex lock and unlock surrounding the notifier call results
in a kernel WARN_ON_ONCE() which will dump a backtrace for the
regulator_notifier_call_chain() when that function call is first made.
The mutex can be controlled using the regulator_lock/unlock() API.

Fixes: 69ca3e58d178 ("regulator: da9063: Add Dialog DA9063 voltage regulators support.")
Suggested-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/da9063-regulator.c