]> asedeno.scripts.mit.edu Git - linux.git/commit
ARM: sunxi: fix a leaked reference by adding missing of_node_put
authorWen Yang <wen.yang99@zte.com.cn>
Tue, 5 Mar 2019 11:34:01 +0000 (19:34 +0800)
committerMaxime Ripard <maxime.ripard@bootlin.com>
Mon, 18 Mar 2019 07:11:12 +0000 (08:11 +0100)
commit2b062a0a00ab31192bb12c0d8c1c71458b12bbed
tree123a2493181bbddeac65ce9ed9bf09581932a44b
parent995c770b6588c84fbe41cd00bc9911c995df2b59
ARM: sunxi: fix a leaked reference by adding missing of_node_put

The call to of_get_next_child returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-sunxi/platsmp.c:55:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 46, but without a corresponding object release within this function.
./arch/arm/mach-sunxi/platsmp.c:138:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 129, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
arch/arm/mach-sunxi/platsmp.c