]> asedeno.scripts.mit.edu Git - linux.git/commit
device property: Fix the length used in PROPERTY_ENTRY_STRING()
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>
Wed, 23 Jan 2019 14:44:16 +0000 (17:44 +0300)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 29 Jan 2019 09:52:40 +0000 (10:52 +0100)
commit2b6e492467c78183bb629bb0a100ea3509b615a5
tree7e8973afe46dc9903b4c72c6ff0f731b6bf8ad44
parentf17b5f06cb92ef2250513a1e154c47b78df07d40
device property: Fix the length used in PROPERTY_ENTRY_STRING()

With string type property entries we need to use
sizeof(const char *) instead of the number of characters as
the length of the entry.

If the string was shorter then sizeof(const char *),
attempts to read it would have failed with -EOVERFLOW. The
problem has been hidden because all build-in string
properties have had a string longer then 8 characters until
now.

Fixes: a85f42047533 ("device property: helper macros for property entry creation")
Cc: 4.5+ <stable@vger.kernel.org> # 4.5+
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
include/linux/property.h