]> asedeno.scripts.mit.edu Git - linux.git/commit
Revert "rpmsg: smd: Create device for all channels"
authorBjorn Andersson <bjorn.andersson@linaro.org>
Thu, 15 Mar 2018 18:12:44 +0000 (11:12 -0700)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 27 Mar 2018 19:58:16 +0000 (12:58 -0700)
commit2bd9b4385fd7ece4f0c64f38bea7726a810a06af
tree005ac89fd88949a0ca7d322305e0aeaef3a6aeff
parent29fc9b3873607d01b1ff1ae077982cf5629010af
Revert "rpmsg: smd: Create device for all channels"

In an effort to pick up channels that are in a funky state we
optimistically tried to open all channels that we found, with the
addition that we failed if the other side did not handshake the opening.

But as we're starting the modem a second time all channels are found -
in a "funky" state - and we try to open them. But the modem firmware
requires the IPCRTR to be up in order to initialize. So any channels we
try to open before that will fail and will not be opened again.

This takes care of the regression, at the cost of reintroducing the
previous behavior of handling of channels with "funky" states.

Reverts commit c12fc4519f60 ("rpmsg: smd: Create device for all channels")

Reported-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/rpmsg/qcom_smd.c