]> asedeno.scripts.mit.edu Git - linux.git/commit
lightnvm: fix uninitialized pointer in nvm_remove_tgt()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Fri, 21 Jun 2019 09:12:00 +0000 (11:12 +0200)
committerJens Axboe <axboe@kernel.dk>
Fri, 21 Jun 2019 09:14:30 +0000 (03:14 -0600)
commit2f5af4ab7de14bd35f3435e6a47300276bbb6c17
tree6599a22dc9f902a9c39290bba7e2a8e536effbcc
parent510fd8ea98fcb586c01aef93d87c060a159ac30a
lightnvm: fix uninitialized pointer in nvm_remove_tgt()

With gcc 4.1:

    drivers/lightnvm/core.c: In function ‘nvm_remove_tgt’:
    drivers/lightnvm/core.c:510: warning: ‘t’ is used uninitialized in this function

Indeed, if no NVM devices have been registered, t will be an
uninitialized pointer, and may be dereferenced later.  A call to
nvm_remove_tgt() can be triggered from userspace by issuing the
NVM_DEV_REMOVE ioctl on the lightnvm control device.

Fix this by preinitializing t to NULL.

Fixes: 843f2edbdde085b4 ("lightnvm: do not remove instance under global lock")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/lightnvm/core.c