]> asedeno.scripts.mit.edu Git - linux.git/commit
powerpc/powernv: Squash sparse warnings in opal-call.c
authorAndrew Donnellan <andrew.donnellan@au1.ibm.com>
Thu, 14 Mar 2019 04:27:27 +0000 (15:27 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Sat, 20 Apr 2019 12:03:19 +0000 (22:03 +1000)
commit2f9196b67237f1e59f2753b2968f8ad6433d4042
tree9a4b64efb14b03690cb6d582e20e8f94e0611ea6
parent80d04b7fabe161a23d143b3bfcfca1b002c23da1
powerpc/powernv: Squash sparse warnings in opal-call.c

sparse complains a lot about opal-call.c:

  arch/powerpc/platforms/powernv/opal-call.c:128:1: warning: symbol 'opal_invalid_call' was not declared. Should it be static?
  arch/powerpc/platforms/powernv/opal-call.c:129:1: warning: symbol 'opal_console_write' was not declared. Should it be static?
  arch/powerpc/platforms/powernv/opal-call.c:130:1: warning: symbol 'opal_console_read' was not declared. Should it be static?

Those symbols are forward declared in opal.h, but we can't include that
because the function signatures in opal.h are different. So instead, just
add an extra forward declaration to the OPAL_CALL macro to shut sparse up.

Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/platforms/powernv/opal-call.c