]> asedeno.scripts.mit.edu Git - linux.git/commit
powerpc/ps3: Use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 8 Jan 2019 21:00:10 +0000 (15:00 -0600)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 14 Jan 2019 09:39:27 +0000 (20:39 +1100)
commit31367b9a01d6a3f4f77694bd44f547d6f738ff28
treea44702e7683c90aa1dfccb128f180fff480cfecf
parent3b702ddd066813952154c22dd76d3b0c10644940
powerpc/ps3: Use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/platforms/ps3/device-init.c