]> asedeno.scripts.mit.edu Git - linux.git/commit
powerpc/perf: Fix MMCRA corruption by bhrb_filter
authorRavi Bangoria <ravi.bangoria@linux.ibm.com>
Sat, 11 May 2019 02:42:17 +0000 (08:12 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 22 May 2019 11:38:20 +0000 (21:38 +1000)
commit3202e35ec1c8fc19cea24253ff83edf702a60a02
tree07a2f0939c84526a9bc367cccb2b958c7e8b8550
parentb59bd3527fe3c1939340df558d7f9d568fc9f882
powerpc/perf: Fix MMCRA corruption by bhrb_filter

Consider a scenario where user creates two events:

  1st event:
    attr.sample_type |= PERF_SAMPLE_BRANCH_STACK;
    attr.branch_sample_type = PERF_SAMPLE_BRANCH_ANY;
    fd = perf_event_open(attr, 0, 1, -1, 0);

  This sets cpuhw->bhrb_filter to 0 and returns valid fd.

  2nd event:
    attr.sample_type |= PERF_SAMPLE_BRANCH_STACK;
    attr.branch_sample_type = PERF_SAMPLE_BRANCH_CALL;
    fd = perf_event_open(attr, 0, 1, -1, 0);

  It overrides cpuhw->bhrb_filter to -1 and returns with error.

Now if power_pmu_enable() gets called by any path other than
power_pmu_add(), ppmu->config_bhrb(-1) will set MMCRA to -1.

Fixes: 3925f46bb590 ("powerpc/perf: Enable branch stack sampling framework")
Cc: stable@vger.kernel.org # v3.10+
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Reviewed-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/perf/core-book3s.c
arch/powerpc/perf/power8-pmu.c
arch/powerpc/perf/power9-pmu.c