]> asedeno.scripts.mit.edu Git - linux.git/commit
serial: 8250_fintek: Fix rs485 disablement on invalid ioctl()
authorLukas Wunner <lukas@wunner.de>
Sat, 28 Oct 2017 09:35:49 +0000 (11:35 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 4 Nov 2017 11:08:53 +0000 (12:08 +0100)
commit3236a965486ba0c6043cf2c7b51943d8b382ae29
tree2cb4bcf7aba7809e963dbd03350b23ed87ce683a
parent9356335faf9f65568dbdb9bba2a07117f69d34c5
serial: 8250_fintek: Fix rs485 disablement on invalid ioctl()

This driver's ->rs485_config callback checks if SER_RS485_RTS_ON_SEND
and SER_RS485_RTS_AFTER_SEND have the same value.  If they do, it means
the user has passed in invalid data with the TIOCSRS485 ioctl()
since RTS must have a different polarity when sending and when not
sending.  In this case, rs485 mode is not enabled (the RS485_URA bit
is not set in the RS485 Enable Register) and this is supposed to be
signaled back to the user by clearing the SER_RS485_ENABLED bit in
struct serial_rs485 ... except a missing tilde character is preventing
that from happening.

Fixes: 28e3fb6c4dce ("serial: Add support for Fintek F81216A LPC to 4 UART")
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_fintek.c