]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/amd: fix fb references in async update
authorHelen Koike <helen.koike@collabora.com>
Mon, 3 Jun 2019 16:56:07 +0000 (13:56 -0300)
committerBoris Brezillon <boris.brezillon@collabora.com>
Tue, 4 Jun 2019 08:13:17 +0000 (10:13 +0200)
commit332af874db929f92931727bfe191b2c666438c81
tree66494865383589c04846d65e57c8ab126d1cac82
parentd985a3533274ef7dd1ccb25cb05a72259b25268f
drm/amd: fix fb references in async update

Async update callbacks are expected to set the old_fb in the new_state
so prepare/cleanup framebuffers are balanced.

Calling drm_atomic_set_fb_for_plane() (which gets a reference of the new
fb and put the old fb) is not required, as it's taken care by
drm_mode_cursor_universal() when calling drm_atomic_helper_update_plane().

Cc: <stable@vger.kernel.org> # v4.20+
Fixes: 674e78acae0d ("drm/amd/display: Add fast path for cursor plane updates")
Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Helen Koike <helen.koike@collabora.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190603165610.24614-3-helen.koike@collabora.com
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c