]> asedeno.scripts.mit.edu Git - linux.git/commit
iw_cxgb4: only clear the ARMED bit if a notification is needed
authorSteve Wise <swise@opengridcomputing.com>
Thu, 30 Nov 2017 17:41:56 +0000 (09:41 -0800)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 7 Dec 2017 21:09:59 +0000 (14:09 -0700)
commit335ebf6fa35ca1c59b73f76fad19b249d3550e86
tree1f25f1ebd3cc579081cc66861f19b0ffee31d3ee
parentd0e312fe3d34c1bc014a7f8ec6540d05e8077483
iw_cxgb4: only clear the ARMED bit if a notification is needed

In __flush_qp(), the CQ ARMED bit was being cleared regardless of
whether any notification is actually needed.  This resulted in the iser
termination logic getting stuck in ib_drain_sq() because the CQ was not
marked ARMED and thus the drain CQE notification wasn't triggered.

This new bug was exposed when this commit was merged:

commit cbb40fadd31c ("iw_cxgb4: only call the cq comp_handler when the
cq is armed")

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/cxgb4/qp.c