]> asedeno.scripts.mit.edu Git - linux.git/commit
virtio_pci: don't kfree device on register failure
authorweiping zhang <zhangweiping@didichuxing.com>
Thu, 21 Dec 2017 12:40:24 +0000 (20:40 +0800)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 1 Feb 2018 14:26:45 +0000 (16:26 +0200)
commit33635bd976fb4c3ccf0cfbb81a8d29bb87760607
treeba99b9f18644729f7010e9c23b47eec9006f65be
parentf2b44cde7e1687ef7886831a3a30df653bda2481
virtio_pci: don't kfree device on register failure

As mentioned at drivers/base/core.c:
/*
 * NOTE: _Never_ directly free @dev after calling this function, even
 * if it returned an error! Always use put_device() to give up the
 * reference initialized in this function instead.
 */
so we don't free vp_dev until vp_dev->vdev.dev.release be called.

Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/virtio/virtio_pci_common.c