]> asedeno.scripts.mit.edu Git - linux.git/commit
regulator: s2mpa01: reduce stack size for probe function
authorArnd Bergmann <arnd@arndb.de>
Wed, 25 Jan 2017 22:20:59 +0000 (23:20 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 26 Jan 2017 11:21:43 +0000 (11:21 +0000)
commit33f0698a52d9ebc089eccff7d2fc376974d7e7bf
tree41350dbbba32ff9a05dd1adcd284096f608cd292
parentd00b74613fb18dfd0a5aa99270ee2e72d5c808d7
regulator: s2mpa01: reduce stack size for probe function

In some rare configurations we can run into rather high kernel stack
consumption:

drivers/regulator/s2mpa01.c:397:1: error: the frame size of 1536 bytes is larger than 1152 bytes [-Werror=frame-larger-than=]

This is probably harmless since it happens only in the probe function,
but there is also a relatively simple workaround, moving the regulator
match data into the device specific structure.

As a small downside, we waste a little memory at runtime. An alternative
approach would free the array at the end of the probe function, which in
turn is a little more complicated.

Fixes: f18792714608 ("regulator: Add support for S2MPA01 regulator")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/s2mpa01.c