]> asedeno.scripts.mit.edu Git - linux.git/commit
staging: iio: ad5933: avoid uninitialized variable in error case
authorArnd Bergmann <arnd@arndb.de>
Mon, 24 Oct 2016 15:22:01 +0000 (17:22 +0200)
committerJonathan Cameron <jic23@kernel.org>
Tue, 25 Oct 2016 17:28:52 +0000 (18:28 +0100)
commit34eee70a7b82b09dbda4cb453e0e21d460dae226
tree6aee928ebd6fab36e8128f04b36cbb30e53e667f
parente866dd8aab76b6a0ee8428491e65fa5c83a6ae5a
staging: iio: ad5933: avoid uninitialized variable in error case

The ad5933_i2c_read function returns an error code to indicate
whether it could read data or not. However ad5933_work() ignores
this return code and just accesses the data unconditionally,
which gets detected by gcc as a possible bug:

drivers/staging/iio/impedance-analyzer/ad5933.c: In function 'ad5933_work':
drivers/staging/iio/impedance-analyzer/ad5933.c:649:16: warning: 'status' may be used uninitialized in this function [-Wmaybe-uninitialized]

This adds minimal error handling so we only evaluate the
data if it was correctly read.

Link: https://patchwork.kernel.org/patch/8110281/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/staging/iio/impedance-analyzer/ad5933.c