]> asedeno.scripts.mit.edu Git - linux.git/commit
btrfs: Remove redundant WARN_ON in walk_down_log_tree
authorNikolay Borisov <nborisov@suse.com>
Mon, 2 Dec 2019 09:40:14 +0000 (11:40 +0200)
committerDavid Sterba <dsterba@suse.com>
Mon, 20 Jan 2020 15:40:51 +0000 (16:40 +0100)
commit36ee0b44ad238c7797e1f7cbefdf75c6cf887101
tree0c63e66c953c8c9b5182c61c0ecdbae1d07eafe2
parent5c4b691eb8958dfdba9bb77d5ac4897bbaeb9064
btrfs: Remove redundant WARN_ON in walk_down_log_tree

level <0 and level >= BTRFS_MAX_LEVEL are already performed upon
extent buffer read by tree checker in btrfs_check_node.
go. As far as 'level <= 0'  we are guaranteed that level is '> 0'
because the value of level _before_ reading 'next' is larger than 1
(otherwise we wouldn't have executed that code at all) this in turn
guarantees that 'level' after btrfs_read_buffer is 'level - 1' since
we verify this invariant in:

    btrfs_read_buffer
     btree_read_extent_buffer_pages
      btrfs_verify_level_key

This guarantees that level can never be '<= 0' so the warn on is
never triggered.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/tree-log.c