]> asedeno.scripts.mit.edu Git - linux.git/commit
udf: fix an uninitialized read bug and remove dead code
authorWenwen Wang <wang6495@umn.edu>
Mon, 15 Apr 2019 17:58:06 +0000 (12:58 -0500)
committerJan Kara <jack@suse.cz>
Wed, 17 Apr 2019 11:13:24 +0000 (13:13 +0200)
commit39416c5872db69859e867fa250b9cbb3f1e0d185
tree0f79e7126a68084f058c8cdcae126c49399bed99
parent5d552ad79630d41ca065457e22a20ae2db5b2441
udf: fix an uninitialized read bug and remove dead code

In udf_lookup(), the pointer 'fi' is a local variable initialized by the
return value of the function call udf_find_entry(). However, if the macro
'UDF_RECOVERY' is defined, this variable will become uninitialized if the
else branch is not taken, which can potentially cause incorrect results in
the following execution.

To fix this issue, this patch drops the whole code in the ifdef
'UDF_RECOVERY' region, as it is dead code.

Signed-off-by: Wenwen Wang <wang6495@umn.edu>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/udf/namei.c