]> asedeno.scripts.mit.edu Git - linux.git/commit
bpf: fix rcu annotations in compute_effective_progs()
authorRoman Gushchin <guro@fb.com>
Fri, 13 Jul 2018 19:41:11 +0000 (12:41 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Wed, 18 Jul 2018 13:01:54 +0000 (15:01 +0200)
commit3960f4fd6585608e8cc285d9665821985494e147
tree3123a66bc1149da0330645b49bb331a482669318
parentd29ab6e1fa21ebc2a8a771015dd9e0e5d4e28dc1
bpf: fix rcu annotations in compute_effective_progs()

The progs local variable in compute_effective_progs() is marked
as __rcu, which is not correct. This is a local pointer, which
is initialized by bpf_prog_array_alloc(), which also now
returns a generic non-rcu pointer.

The real rcu-protected pointer is *array (array is a pointer
to an RCU-protected pointer), so the assignment should be performed
using rcu_assign_pointer().

Fixes: 324bda9e6c5a ("bpf: multi program support for cgroup+bpf")
Signed-off-by: Roman Gushchin <guro@fb.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
kernel/bpf/cgroup.c