]> asedeno.scripts.mit.edu Git - linux.git/commit
ASoC: intel: skl_nau88l25_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in skylake_au...
authorJia-Ju Bai <baijiaju1990@gmail.com>
Mon, 9 Apr 2018 10:48:56 +0000 (18:48 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 16 Apr 2018 10:53:42 +0000 (11:53 +0100)
commit3afce6a4d994dcfc03ca7b6ac6dfa5700e26d152
tree7e4eb0d4fa35e4c51300c285d6de99c26304d3be
parentf3cc330a10493ed5948f7019a78dfa89721858c8
ASoC: intel: skl_nau88l25_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in skylake_audio_probe

skylake_audio_probe() is never called in atomic context.
This function is only set as ".probe" in "struct platform_driver".

Despite never getting called from atomic context,
skylake_audio_probe() calls devm_kzalloc() with GFP_ATOMIC,
which waits busily for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
to avoid busy waiting and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/skl_nau88l25_max98357a.c