]> asedeno.scripts.mit.edu Git - linux.git/commit
bcache: convert cached_dev.count from atomic_t to refcount_t
authorElena Reshetova <elena.reshetova@intel.com>
Mon, 30 Oct 2017 21:46:32 +0000 (14:46 -0700)
committerJens Axboe <axboe@kernel.dk>
Mon, 30 Oct 2017 21:57:54 +0000 (15:57 -0600)
commit3b304d24a718ae779ee9c7f2014dd3b2d0893b70
tree6357ed6aa6ed01c1f81156e8ab9c29c289b85634
parentd59b23795933678c9638fd20c942d2b4f3cd6185
bcache: convert cached_dev.count from atomic_t to refcount_t

atomic_t variables are currently used to implement reference
counters with the following properties:
 - counter is initialized to 1 using atomic_set()
 - a resource is freed upon counter reaching zero
 - once counter reaches zero, its further
   increments aren't allowed
 - counter schema uses basic atomic operations
   (set, inc, inc_not_zero, dec_and_test, etc.)

Such atomic variables should be converted to a newly provided
refcount_t type and API that prevents accidental counter overflows
and underflows. This is important since overflows and underflows
can lead to use-after-free situation and be exploitable.

The variable cached_dev.count is used as pure reference counter.
Convert it to refcount_t and fix up the operations.

Suggested-by: Kees Cook <keescook@chromium.org>
Reviewed-by: David Windsor <dwindsor@gmail.com>
Reviewed-by: Hans Liljestrand <ishkamiel@gmail.com>
Reviewed-by: Michael Lyle <mlyle@lyle.org>
Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/bcache.h
drivers/md/bcache/super.c
drivers/md/bcache/writeback.h