]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/i915: Ignore bogus plane coordinates on SKL when the plane is not visible
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 7 Nov 2016 20:20:54 +0000 (22:20 +0200)
committerJani Nikula <jani.nikula@intel.com>
Wed, 18 Jan 2017 14:31:25 +0000 (16:31 +0200)
commit3bfdfdcbce2796ce75bf2d85fd8471858d702e5d
tree3b61878770f39915459c76d791df377a05caefca
parent4fc020d864647ea3ae8cb8f17d63e48e87ebd0bf
drm/i915: Ignore bogus plane coordinates on SKL when the plane is not visible

When the plane is invisible we may have all sorts of bogus stuff
in the coordinates, which we must ignore or else we might fail the
plane update. This started to happen on SKL when I moved the plane
offset computation to happen in the check phase. Previously we
happily ignored it all since we never called the update_plane hook
with an invisible plane.

Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Cc: drm-intel-fixes@lists.freedesktop.org
Fixes: b63a16f6cd89 ("drm/i915: Compute display surface offset in the plane check hook for SKL+")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98258
Testcase: igt/pm_rpm/legacy-planes
Testcase: igt/pm_rpm/universal-planes
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1478550057-24864-3-git-send-email-ville.syrjala@linux.intel.com
(cherry picked from commit a5e4c7d0aa6784d8abe95c3ceef0da9656d17468)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_display.c