]> asedeno.scripts.mit.edu Git - linux.git/commit
x86/setup: Do not reserve a crash kernel region if booted on Xen PV
authorPetr Tesarik <ptesarik@suse.cz>
Wed, 25 Apr 2018 10:08:35 +0000 (12:08 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 27 Apr 2018 15:06:28 +0000 (17:06 +0200)
commit3db3eb285259ac129f7aec6b814b3e9f6c1b372b
tree4d5bc5058ead6a13380ac4ecbf64f54b7b6347e0
parentb837913fc2d9061bf9b8c0dd6bf2d24e2f98b84a
x86/setup: Do not reserve a crash kernel region if booted on Xen PV

Xen PV domains cannot shut down and start a crash kernel. Instead,
the crashing kernel makes a SCHEDOP_shutdown hypercall with the
reason code SHUTDOWN_crash, cf. xen_crash_shutdown() machine op in
arch/x86/xen/enlighten_pv.c.

A crash kernel reservation is merely a waste of RAM in this case. It
may also confuse users of kexec_load(2) and/or kexec_file_load(2).
When flags include KEXEC_ON_CRASH or KEXEC_FILE_ON_CRASH,
respectively, these syscalls return success, which is technically
correct, but the crash kexec image will never be actually used.

Signed-off-by: Petr Tesarik <ptesarik@suse.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Juergen Gross <jgross@suse.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc: Mikulas Patocka <mpatocka@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Jean Delvare <jdelvare@suse.de>
Link: https://lkml.kernel.org/r/20180425120835.23cef60c@ezekiel.suse.cz
arch/x86/kernel/setup.c