]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/amd/powerplay: Change id parameter type in pp_atomfwctrl_get_clk_information_by_clkid
authorNathan Chancellor <natechancellor@gmail.com>
Fri, 21 Sep 2018 21:01:06 +0000 (14:01 -0700)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 27 Sep 2018 14:40:09 +0000 (09:40 -0500)
commit3ea81f7125dfda80e264e4552b1146c88eff1aa7
treeb570989f2c729e4f1f924c98dbfda7e7773b2129
parent006a0b3d86e7cee0e38d0543c7a6e5dbbf12025e
drm/amd/powerplay: Change id parameter type in pp_atomfwctrl_get_clk_information_by_clkid

Clang generates warnings when one enumerated type is implicitly
converted to another.

drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/ppatomfwctrl.c:532:57:
warning: implicit conversion from enumeration type 'enum
atom_smu11_syspll0_clock_id' to different enumeration type 'BIOS_CLKID'
      (aka 'enum atom_smu9_syspll0_clock_id') [-Wenum-conversion]
        if (!pp_atomfwctrl_get_clk_information_by_clkid(hwmgr,
SMU11_SYSPLL0_SOCCLK_ID, &frequency))

In this case, that is expected behavior. To make that clear to Clang
without explicitly casting these values, change id's type to uint8_t
in pp_atomfwctrl_get_clk_information_by_clkid so no conversion happens.

Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/hwmgr/ppatomfwctrl.c
drivers/gpu/drm/amd/powerplay/hwmgr/ppatomfwctrl.h