]> asedeno.scripts.mit.edu Git - linux.git/commit
cxgb4: sched: use struct_size() in kvzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 31 Jan 2019 00:23:14 +0000 (18:23 -0600)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 Feb 2019 23:12:29 +0000 (15:12 -0800)
commit3ebb18a48cbf03448087f9eef08cbade84fc0118
treec4bca913271b294e70cf3e0a095585b89c1ece10
parent5b053e121ffdec851dc3a7046e9bece287a3c5b1
cxgb4: sched: use struct_size() in kvzalloc()

One of the more common cases of allocation size calculations is
finding the size of a structure that has a zero-sized array at
the end, along with memory for some number of elements for that
array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

instance = kvzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:

instance = kvzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/sched.c