]> asedeno.scripts.mit.edu Git - linux.git/commit
net: sched: don't set tunnel for decap action
authorVlad Buslov <vladbu@mellanox.com>
Mon, 1 Apr 2019 11:16:59 +0000 (14:16 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 2 Apr 2019 20:20:30 +0000 (13:20 -0700)
commit3eed52842b9fd291233c15f65fed34c5d3241183
tree015047dd3e14ceba29bb1b2714f439759d35061e
parent40d0690bd0b681a797d5b9752b72c2890d9d1220
net: sched: don't set tunnel for decap action

Action tunnel_key doesn't have a metadata/tunnel for release(decap) action.
Drivers do not dereference entry->tunnel pointer for that action type, so
this behavior doesn't result in a crash at the moment. However, this needs
to be corrected as a preparation for updating hardware offloads API to not
rely on rtnl lock, for which flow_action code will copy the tunnel data to
temporary buffer to prevent concurrent action overwrite from
invalidating/freeing it.

Fixes: 3a7b68617de7 ("cls_api: add translator to flow_action representation")
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_api.c