]> asedeno.scripts.mit.edu Git - linux.git/commit
locking/rtmutex: Flip unlikely() branch to likely() in __rt_mutex_slowlock()
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Thu, 19 Jan 2017 16:32:34 +0000 (11:32 -0500)
committerIngo Molnar <mingo@kernel.org>
Mon, 30 Jan 2017 10:42:59 +0000 (11:42 +0100)
commit4009f4b3a9d8b74547269f293e6a920adf278996
treed89abc6ec739d45d9f24a4684af2275ffa62fced
parentbcc9a76d5ac426bc45c9e863b1830347827ca77a
locking/rtmutex: Flip unlikely() branch to likely() in __rt_mutex_slowlock()

Running my likely/unlikely profiler for 3 weeks on two production
machines, I discovered that the unlikely() test in
__rt_mutex_slowlock() checking if state is TASK_INTERRUPTIBLE is hit
100% of the time, making it a very likely case.

The reason is, on a vanilla kernel, the majority case of calling
rt_mutex() is from the futex code. This code is always called as
TASK_INTERRUPTIBLE. In the -rt patch, this code is commonly called when
PREEMPT_RT is enabled with TASK_UNINTERRUPTIBLE. But that's not the
likely scenario.

The rt_mutex() code should be optimized for the common vanilla case,
and that is from a futex, with TASK_INTERRUPTIBLE as the state.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170119113234.1efeedd1@gandalf.local.home
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/locking/rtmutex.c